Hi Manuel,

Next time please send patches to the activity maintainer in To: (in
this case this is me) and the sugar-devel list in Cc. Also if you
mention the activity title in the subject line that is useful. I had
skipped over this subject line as something that didn't concern me.

What is the state of this patch? Gonzalo suggested that it was ready
for my review but didn't clarify if this is implementing something
suggested by the design team, if it has seen their acknowledgement,
etc.

One comment on the code:

> +class IconComboBox(gtk.ToolItem):
> +    def __init__(self, icon_filename, **kwargs):
> +        gobject.GObject.__init__(self, **kwargs)

Is there a reason why you don't call the gtk.ToolItem constructor?

Thanks a lot for your work.
Daniel
_______________________________________________
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Reply via email to