On 08/12/2011 01:13 PM, Benjamin Berg wrote:
Hallo,

On Fri, 2011-08-12 at 10:47 +0200, si...@schampijer.de wrote:
This makes the old-style Toolbar hippo free.
[SNIP]
+        self._separator = gtk.HSeparator()
+        self._separator.modify_bg(gtk.STATE_NORMAL,
+                                  style.COLOR_PANEL_GREY.get_gdk_color())
+        self._separator.set_size_request(1, style.TOOLBOX_SEPARATOR_HEIGHT)
          self.pack_start(self._separator, False)

          self._notebook.connect('notify::page', self._notify_page_cb)

We could do the color setting and size request in the theme. But I am
fine with this.

Reviewed-by: Benjamin Berg<benja...@sipsolutions.net

Benjamin



Thanks for the review.

Yes, I think for only a widget only used in one place and that is part of the old style toolbar no need to add it to the theme.

Pushed as: http://git.sugarlabs.org/sugar-toolkit/mainline/commit/3f0822ab1a0f1275b9e10e3ce974ae57e2fb5501

Regards,
   Simon
_______________________________________________
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Reply via email to