Excerpts from Daniel Drake's message of 2011-09-17 13:30:38 +0200:
> Switch to standard GTK containers. Specific coloring details have been
> moved to the theme at the same time.
> 
> Based on earlier work by Raul Gutierrez and Walter Bender.

Thanks for the patch! The code looks good; I haven't tried it out to
verify the layout.

[class ColorPicker]
> +    def _button_press_cb(self, widget, event):
> +        if event.button == 1 and event.type == gtk.gdk.BUTTON_PRESS:

Why do we need to check for BUTTON_PRESS here? We only subscribed to
button-press-event, so what other events could we received?

Reviewed-By: Sascha Silbe <si...@activitycentral.com>

Sascha

-- 
http://sascha.silbe.org/
http://www.infra-silbe.de/

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Reply via email to