On 02/01/2012 03:39 PM, Gonzalo Odiard wrote:
Hi Simon,
I have found the following problems:

Doing "git am":

/home/gonzalo/sugar-jhbuild/source/sugar-toolkit-gtk3/.git/rebase-apply/patch:72:
trailing whitespace.
         if 'description' not in jobject:
warning: 1 line adds whitespace errors.

Done.

Testing:
As you can see in http://dev.laptop.org/~gonzalo/write-anytime.png

1) The icon is not visible, my system does not have a write-journal.svg
file.

The icon from Walter is in this patch: http://lists.sugarlabs.org/archive/sugar-devel/2012-January/035217.html

2) The text inside the description box is white over grey.

Yes, has to be done in the theme.

Another question:

* Is DescriptionEntry a good name? may be is better DescriptionButton?

I am ok with renaming it to DescriptionButton.

Regards,
   Simon

_______________________________________________
Sugar-devel mailing list
[email protected]
http://lists.sugarlabs.org/listinfo/sugar-devel

Reply via email to