On 04/19/2012 04:16 PM, Daniel Drake wrote:
On Mon, Apr 16, 2012 at 8:02 AM, Sascha Silbe<si...@activitycentral.com> wrote:
Excerpts from Simon Schampijer's message of 2012-04-16 10:42:39 +0200:
[extensions/globalkey/viewsource.py]
-BOUND_KEYS = ['0xEC', '<alt><shift>v']
+BOUND_KEYS = ['XF86KbdLightOnOff', '<alt><shift>v']
Is "Keyboard light on/off" really a key that we want to trigger View
Source? Maybe it's what current OLPC images call the key, but that's
fixable.
0xEC and XF86KbdLightOnOff are just different ways of saying the same
thing, both mean "Keyboard light on/off" just expressed using
different notations. So there is no functional or binding change
involved in this patch, we just work around a bug in libegg for which
we have a better solution available when we move to GTK3.
So while the key assignment is definitely strange, it is exactly the
same assignment we've had for longer than I've been involved in the
project.
I agree that the key binding is a bit odd and that we should look at
getting a new key added. I filed a ticket
http://dev.laptop.org/ticket/11788 and I will start to work on it.
In the mean time I think this patch is good to go in.
Thanks,
Daniel
Thanks for taking the review of the key mappings on. Pushed as
http://git.sugarlabs.org/sugar/mainline/commit/70c26fe47618d0e07d3e7925abdd1a053469be03
and noted that in the summary.
Regards,
Simon
_______________________________________________
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
