Thanks, merged On Mon, Aug 3, 2015 at 1:14 PM, Aneesh Dogra <lionane...@gmail.com> wrote:
> Added: https://github.com/godiard/sugarlabs-calculate/pull/29 > > On Fri, Jul 31, 2015 at 6:07 PM, Gonzalo Odiard <godi...@sugarlabs.org> > wrote: > >> Anesh, James, >> As the sugarlabs-caalculate project was inactive from 2013, >> and we had GCI students sending patches, I forked the repository >> and the latest version is here: >> https://github.com/godiard/sugarlabs-calculate >> >> I already added a patch similar to Aneesh patch, but made the same >> mistake, >> >> Aneesh, please send a patch fixing the error pointed by James to apply in >> the new repository. >> >> Gonzalo >> >> >> >> On Fri, Jul 31, 2015 at 3:05 AM, James Cameron <qu...@laptop.org> wrote: >> >>> That's almost correct. The license should be after the copyright. So >>> move line 17 to line 2. ;-} >>> >>> On Fri, Jul 31, 2015 at 10:47:00AM +0530, Aneesh Dogra wrote: >>> > Here you go: >>> > [1]https://github.com/lionaneesh/sugarlabs-calculate/commit/ >>> > 8df47288de11b9fdc61e4811515110f7b44ee925 >>> > >>> > On Thu, Jul 30, 2015 at 9:34 AM, James Cameron <[2]qu...@laptop.org> >>> wrote: >>> > >>> > G'day Aneesh, >>> > >>> > Thanks for coming back to us on this. >>> > >>> > Yes, you can do something, and you are the only person who can do >>> it, >>> > because you are the copyright owner. >>> > >>> > You just have to edit a file. >>> > >>> > As an example of a good file, look at plotlib.py, see how it has >>> both >>> > a copyright (line 2) and a license (lines 4-16). >>> > >>> > [3] >>> https://github.com/lionaneesh/sugarlabs-calculate/blob/sugar-0.94/ >>> > plotlib.py >>> > >>> > It is the layout.py file with a problem. >>> > >>> > [4] >>> https://github.com/lionaneesh/sugarlabs-calculate/blob/sugar-0.94/ >>> > layout.py >>> > >>> > Clone the source code in your git repository >>> > [5]https://github.com/lionaneesh/sugarlabs-calculate >>> > >>> > Open the file layout.py, edit it, add the license, commit the >>> changes, >>> > and then push to your repository. >>> > >>> > That's all! >>> > >>> > If you can't push for some reason, you can prepare a git patch and >>> > post it as a reply. As long as it comes from you. >>> > >>> > References: >>> > >>> > [6] >>> http://lists.sugarlabs.org/archive/sugar-devel/2015-June/050399.html >>> > >>> > On Mon, Jul 27, 2015 at 12:15:11PM +0530, Aneesh Dogra wrote: >>> > > Hello all, >>> > > >>> > > Sorry. I was on a long vacation. Getting back on my emails now. >>> Can I do >>> > > something about this? >>> > > >>> > > On Fri, Jun 19, 2015 at 3:21 AM, Gonzalo Odiard <[1][7] >>> > godi...@sugarlabs.org> >>> > > wrote: >>> > > >>> > > I am afraid you will find many other activities where the >>> license >>> > notation >>> > > is >>> > > in the same state. >>> > > If the current maintainer can't solve the problem, I have >>> nothing to >>> > do, >>> > > but then don't complain :) >>> > > >>> > > Gonzalo >>> > > >>> > > On Thu, Jun 18, 2015 at 6:39 PM, James Cameron <[2][8] >>> > qu...@laptop.org> wrote: >>> > > >>> > > I'm with Jonas on this. >>> > > >>> > > The fault is a copyright statement in a work without a >>> license, >>> > and >>> > > yes, only the original copyright owner can correct it. >>> > > >>> > > In my opinion, that correction can be a mail reply from >>> the >>> > original >>> > > copyright owner saying "Gonzalo, please add this license >>> short >>> > text", >>> > > or "Gonzalo, please remove the copyright line." >>> > > >>> > > (Best is the first). >>> > > >>> > > Or it can be a patch. >>> > > >>> > > But it's not something the new maintainer can _ever_ do, >>> alone. >>> > > >>> > > I now have to reconsider inclusion of this activity. >>> Don't let >>> > that >>> > > happen again! ;-) >>> > > >>> > > -- >>> > > James Cameron >>> > > [3][9]http://quozl.linux.org.au/ >>> > > >>> > > >>> > > >>> > > -- >>> > > Gonzalo Odiard >>> > > >>> > > SugarLabs - Software for children learning >>> > > >>> > > -- >>> > > Regardless, I hope you're well and happy - >>> > > Aneesh >>> > > >>> > > References: >>> > > >>> > > [1] mailto:[10]godi...@sugarlabs.org >>> > > [2] mailto:[11]qu...@laptop.org >>> > > [3] [12]http://quozl.linux.org.au/ >>> > >>> > -- >>> > James Cameron >>> > [13]http://quozl.linux.org.au/ >>> > >>> > -- >>> > Regardless, I hope you're well and happy - >>> > Aneesh >>> > >>> > References: >>> > >>> > [1] >>> https://github.com/lionaneesh/sugarlabs-calculate/commit/8df47288de11b9fdc61e4811515110f7b44ee925 >>> > [2] mailto:qu...@laptop.org >>> > [3] >>> https://github.com/lionaneesh/sugarlabs-calculate/blob/sugar-0.94/plotlib.py >>> > [4] >>> https://github.com/lionaneesh/sugarlabs-calculate/blob/sugar-0.94/layout.py >>> > [5] https://github.com/lionaneesh/sugarlabs-calculate >>> > [6] >>> http://lists.sugarlabs.org/archive/sugar-devel/2015-June/050399.html >>> > [7] mailto:godi...@sugarlabs.org >>> > [8] mailto:qu...@laptop.org >>> > [9] http://quozl.linux.org.au/ >>> > [10] mailto:godi...@sugarlabs.org >>> > [11] mailto:qu...@laptop.org >>> > [12] http://quozl.linux.org.au/ >>> > [13] http://quozl.linux.org.au/ >>> >>> -- >>> James Cameron >>> http://quozl.linux.org.au/ >>> >> >> >> >> -- >> Gonzalo Odiard >> >> SugarLabs - Software [for | by] children learning >> > > > > -- > Regardless, I hope you're well and happy - > Aneesh > -- Gonzalo Odiard SugarLabs - Software [for | by] children learning
_______________________________________________ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel