Hi, Today, I had a meeting with Michaël and had discussions about work items from the last week which basically includes: - Add i18n translation in the app. - Start working on the "Request for Deployments" feature.
Problems experienced last week: - Had difficulty finding suitable i18n library for client-side translations. In the end, we used i18next with jquery-i18next and modified jquery-i18next code to allow moment-js localisation and taking JS objects as input. Here is a list of tasks that we have decided for this week: - Connect Sugarizer-School-Portal with helm and add a feature to install a simple chart from the interface. - Add more translations for the Deployments part and update the error codes. - Fix bugs and add improvements in current Sugarizer-School-Portal PFA slack logs for reference. Next meeting is scheduled for next Monday. Regards, Nikhil
Michaël Ohayon 2:45 PM Yes let’s begin! Nikhil 2:45 PM How are you doing? Michaël Ohayon 2:45 PM Great and you? How are you doing? Nikhil 2:46 PM I'm doing great 2:46 We still have a week before GSoC coding officially begins. Michaël Ohayon 2:47 PM Yes :smile: Nikhil 2:47 PM Last week tasks were: Add i18n translation in the app. Start working on the "Request for Deployments" feature. Michaël Ohayon 2:48 PM :thumbsup: Nikhil 2:48 PM I used i18next, jqeury-i18next, and moment-with-locale for localisation. 2:49 The translation is completely client based. You don't need to refresh the browser to update the translation. I had to modify the code of this library (https://github.com/i18next/jquery-i18next) to allow moment.js dynamic translation. I also made some changes to allow passing JS Objects as parameters. The library has MIT license to I think it'll be fine to freely modify its code. The translation set-up took more time than expected. 2:50 I have also added a view for the Client Sign-up. 2:52 I started working on the "Request for Deployments" feature. I have added a view using which Clients/Moderators/Admins and create a Deployment request. 2:53 Only Admin can approve/reject the deployment request. Only Admin can start/stop the deployment. (The code to actually start/stop deployment is not added yet) 2:53 Moderators can view all the deployments but can only edit the deployments created by them. (edited) 2:54 Clients can only view and edit the deployments created by them. 2:54 Admin can view/edit any deployment. 2:54 The school-short-name once set cannot be edited Michaël Ohayon 2:55 PM That is nice, maybe you could list that under a table in the README Nikhil 2:55 PM Oh. Okay 2:56 Should I create a Features section in the README and mention these points under that section? (edited) Michaël Ohayon 2:56 PM :smile: that may help you in a few weeks to be sure what you are willing to achieve 2:56 Yes that is great Nikhil 2:56 PM Cool 2:57 What are your views about the Sugarizer-School-Portal-Server? You were just tested it 2:57 What do you think about the interface of the Deployments view? Michaël Ohayon 2:58 PM It is nice, I did not have struggle using it Nikhil 2:58 PM Great! Michaël Ohayon 2:59 PM Maybe you could give hints about default microk8s helm location Nikhil 3:00 PM Give hints where exactly? 3:00 I have mentioned in the readme to modify the helm location in the config file. 3:00 This week I was planning to work further on the Deployments feature. Connect with helm and install some simple charts (Not Sugarizer-Chart) Michaël Ohayon 3:01 PM Yes, but using microk8s I guess the path is always the same Nikhil 3:01 PM Readme: Changes: - Modify line 17 in node-modules/node-helm/helm.js. Change this.executer.callByArguments(command, callbackHandler(done)); to this.executer.callByArguments(command, callbackHandler(done, true), true); - Update env/config.ini and set helm_binary to the location to helm binary in your system. Michaël Ohayon 3:01 PM So maybe you could provide yours to avoid looking for it :smile: Nikhil 3:03 PM I think when microk8s finishes installation, it can be accessed with microk8s.helm3 from the terminal (edited) Michaël Ohayon 3:03 PM Yes I went looking for the path 3:03 Can I leave microk8s.helm3 ? 3:03 It is path or binary name :thinking_face: ? Nikhil 3:03 PM Yeah 3:03 It works for me Michaël Ohayon 3:04 PM Ah nice, maybe you could add that in the readme then :smile: :+1: 1 3:04 I was thinking path was required :smile: Nikhil 3:04 PM Okay 3:06 I have finished the translation part, now I just have to keep updating the <lang>.json files to add more translations Michaël Ohayon 3:06 PM :smile: 3:06 That is nice 3:06 Well done :ok_hand: Nikhil 3:07 PM So this week I'll add more translations for the Deployments part. I also have to update the error codes and add their meaning in <lang>.json file. Michaël Ohayon 3:08 PM I can give the fr.json a look :upside_down_face: Nikhil 3:08 PM I'll also make some improvements like improve the search feature to not just search for name but search for Username, email, school-short-name too 3:09 Sure. I'm just adding the english and hindi translations. 3:09 It would be great if you can help with fr.json Michaël Ohayon 3:10 PM Yes sure :smile: Nikhil 3:11 PM Can you do that sometime later this week. I need to add a few more keys yet. I'll message on the group when it's ready. Maybe end of the week will be fine, by then I would have integrated the node-helm part. 3:12 Coming to the node-helm part, should I create a fork of the repo and start working with that or should we directly use it's code in our project? Michaël Ohayon 3:14 PM Yes I think 3:14 You should fork your own 3:14 It will be easier for maintenance 3:14 Maybe you could then request your modification to go upfront Nikhil 3:16 PM Okay. I'll start working on the node-helm fork this week. Pinned by you 3:16 This week tasks are: Connect Sugarizer-School-Portal with helm and add feature to install simple chart from the interface. Add more translations for the Deployments part and update the error codes. Fix bugs and add improvements in current Sugarizer-School-Portal 3:17 I was thinking of modifying the fork and publishing it on npmjs.com from where it can be pulled directly. Michaël Ohayon 3:19 PM Yes that is very nice, I do not think asking to modify libs directly is great :smile: 3:19 Maybe you could do the same with the translation lib ? :thinking_face: Nikhil 3:22 PM Actually I have modified it to use moment.js functions and add custom feature to take JS Objects as parameters. I don't think they'll be willing to merge these features. I have not installed that library using npm, it's code is present in the public/js directory of the project Michaël Ohayon 3:22 PM The only thing that bothers me is that if we have a bug in the lib 3:23 we have to redo the page Nikhil 3:24 PM Okay. So we can create a fork of the library and make the changes in our fork of the library. If their library is updated, we will be able to track the changes. Michaël Ohayon 3:25 PM Yes let’s do that :slightly_smiling_face: :+1: 1 Nikhil 3:25 PM Is there anything else to discuss? Michaël Ohayon 3:26 PM I think we are great :smile: Nikhil 3:26 PM Should I add something in the problems faced last week section? Michaël Ohayon 3:26 PM Yes, you can grab some parts of our past discussion for the recap I think 3:26 I will think of that lib translation if there are other ways Nikhil 3:27 PM Okay 3:27 So I'll add: Had difficulty finding suitable i18n library for client based translations. In the end, we used i18next with jquery-i18next and modified jquery-i18next code to allow moment-js localisation and taking JS objects as input. (edited) 3:30 Will this be fine? Michaël Ohayon 3:30 PM That is nice :slightly_smiling_face: Nikhil 3:30 PM Should we end this meeting? Michaël Ohayon 3:31 PM Yes that is good for me :smile: Nikhil 3:32 PM Bye. Have a nice day! Pinned by you Michaël Ohayon 3:32 PM Maybe you could add some lines about the installation of mongo in the README :thinking_face: Or point to a link maybe :+1: 1 3:32 But that is nice, I had fun seeing my deployments ! Nikhil 3:32 PM Oh. Alright!
_______________________________________________ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
