Hi, Today, I had a meeting with Michaël and had discussions about work items from the last week which basically includes: - Integrate Photon for the address in the SSP. - Make the addEditDeployment and addEditUser view more descriptive. - Test MGOB on Azure and GKE. - Test SSP on Azure AKS with GCP Cloud DNS.
Problems experienced last week: None Here is a list of tasks that we have decided for this week: - Add Deployment Description field to Request Deployment form (With word limit). - Update documentation and finalise it for final submission. - Do final submission. - Update the setup script to support AWS and optional email validation. - Send verification email if the deployment gets approved/rejected. PFA slack logs for reference. Next meeting is scheduled for next Monday. Regards, Nikhil
Nikhil 6:33 PM Hello @Michaël Ohayon 6:33 How are you doing? Michaël Ohayon 6:35 PM Fine, what about you? Nikhil 6:36 PM My schedule is little tough these days due to classes :sweat_smile:. I think it'll get better after 18th (end of the classes) Michaël Ohayon 6:36 PM Yeah I understand 6:36 That a whole new life so that will pay Nikhil 6:37 PM Today is the last day of GSoC coding period according to the timeline 6:37 I was having a look at the work submission guidelines: https://developers.google.com/open-source/gsoc/help/work-product 6:38 It says If your GitHub repository is single purpose for GSoC, add a README.md with more detail. Michaël Ohayon 6:38 PM I was thinking that you should point to the “sugarizer-school-portal repo” 6:38 It should be sufficent Nikhil 6:38 PM Yeah. Exactly, the readme repo Michaël Ohayon 6:38 PM You may add something about gsoc in there Nikhil 6:39 PM Um... We can write that this project was created as a part of Google Summer of Code 2020 program. What do you say? Michaël Ohayon 6:40 PM Yeah that is sufficent 6:40 I have no feedbacks about their validation process Nikhil 6:40 PM I think you're the one who is going to evaluate. So final decision is yours Michaël Ohayon 6:40 PM But I did not have any students failing or having issues for missing info in the Repo 6:41 Yeah, we are making the pass or fail. What they do after, we do not know but the decision is taken (edited) Nikhil 6:42 PM Yeah. Last year I messed up :sweat_smile:. I created a blog post describing the project. Then in the submission page, there was a section for "Project Link" or something like that. In that field, I added the link to the repository instead of the blog. The repo was not mine, I just contributed to it. Hopefully I passed the evaluation. 6:43 Link to the top of the project's primary source repository. I.e. if you're working on cpython, this link is not useful: https://github.com/python/cpython This was under bad examples. 6:43 But in our case, it'll be fine. If your GitHub repository is single purpose for GSoC, add a README.md with more detail. Michaël Ohayon 6:44 PM If they look at commits they’ll see your name everywhere :smile: 1 Nikhil 6:45 PM So I'll update all the documentation. I also need to update the setup script. It does not supports azure and email validation yet. Nikhil 6:49 PM Can you include some compliments in "Feedback for your student" section of the Final Evaluation :stuck_out_tongue_closed_eyes:. I'm going to share the final evaluation with feedback on social media. It'll look awesome if you do so :smile:. 2 replies Last reply today at 7:59 PMView thread Michaël Ohayon 6:50 PM Haha I always try to get into that field things you did well and a few ways to get even better 6:50 But no worries, I think you nailed things as we will be able to deploy quick and easily Nikhil 6:51 PM Okay! 6:51 So coming back to the last week tasks: - Integrate Photon for the address in the SSP. - Make the addEditDeployment and addEditUser view more descriptive. - Test MGOB on Azure and GKE. - Test SSP on Azure AKS with GCP Cloud DNS. Michaël Ohayon 6:51 PM But yeah I understand that it helps students a lot Nikhil 6:51 PM Yeah :smile: 6:52 Integrate Photon for the address in the SSP. It's integrated. You can test it on amazon.sugarizer.tools 6:53 Yesterday Lionel was facing an issue because the certificates of https://photon.komoot.de/ were expired. It's working fine now. (edited) Michaël Ohayon 6:54 PM Yeah I tried it on my side with some schools, autocomplete was nice :slightly_smiling_face: Nikhil 6:56 PM But we might face that issue if https://photon.komoot.de stops working in future. I modified the Select2 code such that if the API gets an error, it should still work. 6:56 Let me share its screenshot 6:59 Okay. So that issue is that I managed to add a fail safe if the API starts giving error response (I tested on error 404) 6:59 But if the target server stops responding at all, then the failsafe fails :sweat_smile: Michaël Ohayon 7:00 PM Mmm it does not timeout ? 7:00 Or go into some error you can catch ? Nikhil 7:00 PM Like in this case. There is no response from the server. I set the network to offline before making the request. image.png image.png 7:02 If we get some kind of error response from API, in that case the suggested text is the written text. Michaël Ohayon 7:03 PM Perfect 7:03 We won’t get stuck this way :thumbsup: Nikhil 7:03 PM So currently, It should work even if the API reaches its limit and starts giving error. But I need to look into Select2 code to implement some fix if the API server stops responding at all. (edited) Nikhil 7:09 PM Next task was: Make the addEditDeployment and addEditUser view more descriptive. The objective was to make it little more descriptive for Teachers (Clients). When I looked at "addEditUser" I felt like there is no need to make it more descriptive and Teachers can only see the Profile View. I have added a small message to make "addEditDeployment" more descriptive for Teachers (Clients). :+1: 1 7:09 image.png image.png 7:09 Actually there was a point by Lionel. He said we require a "Description" field 7:11 He wanted to add a text field in the form for Deployment Description. Instead, I was confusing it for "add description to the view". 7:11 Add a text field "Deployment Description" in the Deployment Request form. 7:12 I'll add that new text field in the form. Should we keep a word limit for the description? What should be the word limit? (edited) Michaël Ohayon 7:12 PM https://wordcounter.io/faq/how-many-pages-is-5000-words/#:~:text=Double%20spaced%2C%205000%20words%20is,output%20should%20be%20very%20similar. Word CounterWord Counter How Many Pages is 5000 Words? – Word Counter How Many Pages is 5000 Words? Page count depends on a number of factors, including font size and type, margins, spacing, paragraph structure and more. (503 kB) https://wordcounter.io/assets/images/word-counter.jpg 7:12 Pages by Word Count 7:13 250 words ? 7:13 I’m not sure Nikhil 7:15 PM Okay. Maybe @Lionel can give an appropriate word limit as he has good field experience with Sugarizer deployments. :+1: 1 7:16 Test MGOB on Azure and GKE. 7:17 We tested MGOB on AWS with GCloud Bucker, Azure Storage, Amazon S3 bucket. They all seem to work fine. Michaël Ohayon 7:17 PM Yeah I saw all the artifacts this is so nice :smile: 1 Nikhil 7:18 PM Test SSP on Azure AKS with GCP Cloud DNS. We tested Sugarizer Deployment installed on Amazon EKS with GCP, AWS and Azure Cloud DNS. They all seem to work perfectly. 7:19 I have also added some DNS records on Azure Cloud DNS for email verification which was required for SMTP based mailing. Michaël Ohayon 7:19 PM Yeah aws was a pain but it's worth it :smile: 1 Nikhil 7:20 PM Yeah. Now we can use 3 Cloud DNS provider and 3 Kubernetes Providers with cross support. 7:21 Apart from the assigned tasks for this week, We added Amazon AWS support to the Sugarizer Chart and Sugarizer School Portal Chart. (edited) Michaël Ohayon 7:21 PM I guess its to avoid email spamming 7:21 Or some validation that you're required to add those domain email lines (edited) Nikhil 7:22 PM Actually if domain is not validated, anyone can send email from any email address. It's just a security measure. Michaël Ohayon 7:24 PM :D Nikhil 7:25 PM We also added MailGun as SMTP to current SSP. 7:26 What do you think about this? https://sugarizer-workspace.slack.com/archives/C011B327MGX/p1598211192005500 Lionel Cool, another idea I had - I don't know if it make sense, should be discuss with @Michaël Ohayon - is "Demo request". The idea is to auto approve requests for demo - means deployment limited to a very short period of time (let's say 1h max). Once the e-mail is validated, the deployment will be auto-launched but will be automatically removed at the end of pre-determined period of time. It will allow everyone (including us) to test/demo the service easily. What do you think? Posted in #sugarizer-schoolportal | Today at 1:03 AM | View message Michaël Ohayon 7:26 PM It is fun for sure Nikhil 7:27 PM I think that this is a good idea. It will have positive marketing effect. But it'll be unstable for now. Michaël Ohayon 7:27 PM I’m not sure how we can “timeout” things Nikhil 7:27 PM Yeah Michaël Ohayon 7:28 PM Maybe on the server we can hook to notifications on collections update Nikhil 7:28 PM If we implement it in a hurry, then it can lead to loopholes. (edited) Michaël Ohayon 7:28 PM I think mongodb handles that 7:28 Or allows it 7:28 :slightly_smiling_face: 7:29 It could be a table like timeouts 7:29 And we could trigger based on that Nikhil 7:29 PM Maybe on the server we can hook to notifications on collections update For timeouts? Michaël Ohayon 7:29 PM Yeah 7:29 https://stackoverflow.com/questions/38472125/delete-mongodb-document-at-specific-time/38536616#:~:text=To%20delete%20MongoDB%20document%20in,a%20certain%20amount%20of%20time.&text=create%20this%20index-,TestSchema.,%2C%20%7B%20expireAfterSeconds%3A%205%20%7D%20)%3B Stack OverflowStack Overflow Delete MongoDB document at specific time I am looking into deleting a document at a specific time. const TestSchema = new Schema({ expire_at: { type: Date, }, }, { timestamps: true, }); TestSchema.index({expire_at: 1}, {expireAfterSe... 7:29 https://docs.mongodb.com/manual/reference/method/db.collection.watch/ docs.mongodb.comdocs.mongodb.com db.collection.watch() — MongoDB Manual (4 kB) http://s3.amazonaws.com/info-mongodb-com/_com_assets/cms/mongodb-for-giant-ideas-bbab5c3cf8.png 7:29 Combining the two could do something nice Nikhil 7:31 PM Yeah, but there can be several loopholes. Currently a deployment need to be approved before deploying it. So we need to temporarily approve the deployment then deploy it. Or just deploy it without approving with some kind of timeout. If many users request a deployment and we enable trial for each of them, then our cluster will get overloaded. Michaël Ohayon 7:32 PM Yeah that needs to be thinked Nikhil 7:33 PM In case of server failure, the deployment will be still there but it won't be monitored since it's not approved. 7:33 I think we should not implement it for now but keep it as a future feature. 7:34 I mean we're going to get bugs on SSP when it goes on production. 7:35 If we add this feature now, we can get even more bugs. Plus it's almost the end of GSoC so we can't expect weekly bug fixes on SSP :sweat_smile:. Nikhil 7:43 PM I think for this week: Add Deployment Description field to Request Deployment form (With word limit). Update documentation and finalise it for final submission. Do final submission. Update the setup script to support AWS and optional email validation. 7:43 Yeah, there was another point by Lionel. Send verification email if the deployment gets approved. 7:44 I think these tasks will be enough for the last week? Add Deployment Description field to Request Deployment form (With word limit). Update documentation and finalise it for final submission. Do final submission. Update the setup script to support AWS and optional email validation. Send verification email if the deployment gets approved/rejected. (edited) Michaël Ohayon 7:59 PM Yeah I guess so 7:59 We’re almost done :smile: Nikhil 7:59 PM Yep 8:02 I think we can create an issue for this task on the repo: https://sugarizer-workspace.slack.com/archives/C011B327MGX/p1598211192005500 When something stable comes out, we can thoroughly test it and merge it. Lionel Cool, another idea I had - I don't know if it make sense, should be discuss with @Michaël Ohayon - is "Demo request". The idea is to auto approve requests for demo - means deployment limited to a very short period of time (let's say 1h max). Once the e-mail is validated, the deployment will be auto-launched but will be automatically removed at the end of pre-determined period of time. It will allow everyone (including us) to test/demo the service easily. What do you think? Posted in #sugarizer-schoolportal | Today at 1:03 AM | View message Michaël Ohayon 8:02 PM Yeah that is a great idea (edited) Nikhil 8:03 PM I need to submit the code for final evaluation before 31st. 8:04 I'll message you before submitting the final code. Michaël Ohayon 8:04 PM Yeah sure 8:05 You can submit a few days before to prevent from any issue Nikhil 8:05 PM Yeah. Right 8:05 I'll try to submit it early. We can modify the docs even after submitting the final code. 8:06 Should we end this meeting? Michaël Ohayon 8:06 PM Yeah ! 8:06 Thanks again for your good work 8:06 Can’t wait to see it live Nikhil 8:06 PM Okay. Have a nice day! 8:06 Yeah
_______________________________________________ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
