Hi Tomeu, Patch looks great and should really be an improvement. Not sure we need the debug messages for the timers logging.debug('Remove date updating timer').
As a general note running a pylint for the journal would be nice as well (should do that for the browse now as well :). Though pylint output is not perfect yet it improves quality a bit. r+ Simon Tomeu Vizoso wrote: > Hi, > > during activity launching, a new journal entry is created. As the > journal is listening for changes in the DS and updating its UI > accordingly, if that update operation is costly in terms of CPU, the > activity startup process can be affected. > > This patch avoids the journal updating itself when it is not the > active activity, and in tests with 3500 entries, I saw a saving of 3s. > during activity startup. > > Thanks, > > Tomeu > > > ------------------------------------------------------------------------ > > _______________________________________________ > Sugar mailing list > Sugar@lists.laptop.org > http://lists.laptop.org/listinfo/sugar _______________________________________________ Sugar mailing list Sugar@lists.laptop.org http://lists.laptop.org/listinfo/sugar