I'm away from my machine, but quick response, I'll say more later.
On Sat, Jun 7, 2008 at 6:51 AM, Marco Pesenti Gritti <[EMAIL PROTECTED]> wrote: > I'm still getting a few pylint errors, you don't?. I was just getting "defined outside of __init__" for ActivityBundle.manifest ... I don't know how I'm supposed to fix that, since it is defined from a subroutine of __init__ that is also useful elsewhere. > Also can you please > answer the question/notes I posted before I go ahead an do a full > review? OK, here: * Please run pylint on the changed files. You can use sugar-jhbuild/scripts/data > > /pylintrc. That will catch several problems > and nitpicks that I'd ask you to fix anyway. Done, I think, I will check again later. > > * I dont understand all the > warnings.warn(MalformedBundleException(...)). What's the purpose of > those. Shouldn't they be real exceptions? What's the advantage of > using the warnings module over logging.warning? fixed in the patch I reposted * I'm not sure what you are using dest_dir for, but it looks like it should be part of Config. again, fixed. * Why are you moving the activity and env imports inline. I answered that in my previous email: to make it easier to use these files without having the rest of Sugar installed.
_______________________________________________ Sugar mailing list [email protected] http://lists.laptop.org/listinfo/sugar
