On Thu, Sep 11, 2008 at 2:39 AM, Marco Pesenti Gritti <[EMAIL PROTECTED]> wrote: > On Wed, Sep 10, 2008 at 2:58 PM, Tomeu Vizoso <[EMAIL PROTECTED]> wrote: >>> * I wonder if it would be easier to add a "builtin" journal activity >>> to the registry, instead of special casing the model. >> >> Not sure, a couple of ifs may be less confusing. > > Hmmm not fully convinced, but I don't have a strong feeling. Something > we can easily refactor anyway. > > The patch seem to have caused some pylint regressions: > > http://buildbot.sugarlabs.org/builders/fedora9-x86_64-quick/builds/177/steps/pylint/logs/stdio
Fixed > and some warnings at runtime (they don't prevent the activity to start): > > http://buildbot.sugarlabs.org/builders/fedora9-x86_64-quick/builds/177/steps/ui-check/logs/stdio Looks to be a 64 bit problem. File "/home/buildbot/slave/fedora9-x86_64-quick/build/install/lib/python2.5/site-packages/olpc/datastore/xapianindex.py", line 471, in search checkatleast=sys.maxint) File "/home/buildbot/slave/fedora9-x86_64-quick/build/install/lib/python2.5/site-packages/secore/searchconnection.py", line 610, in search mset = enq.get_mset(startrank, maxitems, checkatleast) OverflowError: in method 'Enquire_get_mset', argument 4 of type 'Xapian::doccount' sys.maxint is too big for Xapian. Any better idea than hardcoding 2**31-1 ? Regards, Tomeu _______________________________________________ Sugar mailing list Sugar@lists.laptop.org http://lists.laptop.org/listinfo/sugar