Hello Michele, I mostly agree with your understanding of the code and have opened a ticket (http://sumo-sim.org/trac.wsgi/ticket/1382). I think myMaxGap and myDetectorGap being in seconds are correct, though. Frankly, we haven't used MSActuatedTrafficLight for quite some time and always used a traci-version for that behavior. If you have a patch for those issues we'll be happy to take it. Beware that MSAgentBasedTrafficLight is probably in an even worse state. best regards, Jakob
2014-07-17 2:01 GMT+02:00 Michele Covell <[email protected]>: > After spending a reasonable amount of time looking at this part of the code > base, I think there are two bugs: > (1) The parameters myMaxGap, myPassingTime, MyDetectorGap, all need to get > multiplied by DELTA_T (so that they are in the right units for the way they > are used) > (2) In MSActuatedTrafficLightLogic::duration(): The way that newduration > is set/used is not internally consistent (and, for one piece, not > consistent with the way the return value is being used outside of this > routine. newduration should be the desired extension to the current light > phase duration. That means that it should not be set to minDuration (line > 145) but instead set to DELTA_T and it should not be limited by maxDuration > (line 162) but instead should be limited by the difference between > maxDuration and the current duration. > > Please let me know if I am misunderstanding this code. My simulations with > actuated traffic lights are better behaved when I make these changes (but > it is not that either way causes a complete breakdown in operation). > > Thanks, Michele > > (I'd submit this as a ticket but I seem to be having trouble getting access > to the ticket system....) > > ------------------------------------------------------------------------------ > Want fast and easy access to all the code in your enterprise? Index and > search up to 200,000 lines of code with a free copy of Black Duck > Code Sight - the same software that powers the world's largest code > search on Ohloh, the Black Duck Open Hub! Try it now. > http://p.sf.net/sfu/bds > _______________________________________________ > sumo-user mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/sumo-user > ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ sumo-user mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/sumo-user
