Excerpts from William Morgan's message of Sat Aug 22 10:10:04 -0400 2009: > This looks good. Two minor questions before I apply: > > Reformatted excerpts from Rich Lane's message of 2009-08-16: > > The regexes in this function are very expensive, so caching improves > > performance significantly for queries and slightly for indexing. > > When you say this affects query performance, is it just the contact-list > query, or is there some other mechanism by which this is slowing down > regular queries?
Actually, your question prompted me to wonder why we're calling Person.from_address on this path at all. With a little support from Message we can completely avoid Message#parse_header. I've just sent in a patch that does this. Please apply that rather than the from_address cache. The performance improvement from the new patch is slightly better than that of the cache. Depending on the benchmark I see the time taken by ThreadIndexMode#load_n_threads decrease by 1/2 to 2/3. _______________________________________________ sup-talk mailing list [email protected] http://rubyforge.org/mailman/listinfo/sup-talk
