Hey Kenney,
On 2.3.1 I'd already replaced this code with UrlUtils which seemed to
cover all the cases consistently, so I merged it over to trunk too
(sorry, I'd just forgotten to do that previously).
Can you double check I haven't missed anything by re-running it
against where this was causing a problem for you?
Thanks,
Brett
On 01/06/2007, at 2:24 AM, [EMAIL PROTECTED] wrote:
Author: kenney
Date: Thu May 31 09:24:35 2007
New Revision: 543178
URL: http://svn.apache.org/viewvc?view=rev&rev=543178
Log:
Fix 'isDirectory' check; classpath elements that are directories
MUST end in a '/', and 'file://localhost//foo' is NOT a directory
according to java.io.File - it's an url!
Modified:
maven/surefire/trunk/surefire-booter/src/main/java/org/apache/
maven/surefire/booter/ForkConfiguration.java
Modified: maven/surefire/trunk/surefire-booter/src/main/java/org/
apache/maven/surefire/booter/ForkConfiguration.java
URL: http://svn.apache.org/viewvc/maven/surefire/trunk/surefire-
booter/src/main/java/org/apache/maven/surefire/booter/
ForkConfiguration.java?view=diff&rev=543178&r1=543177&r2=543178
======================================================================
========
--- maven/surefire/trunk/surefire-booter/src/main/java/org/apache/
maven/surefire/booter/ForkConfiguration.java (original)
+++ maven/surefire/trunk/surefire-booter/src/main/java/org/apache/
maven/surefire/booter/ForkConfiguration.java Thu May 31 09:24:35 2007
@@ -229,8 +229,7 @@
for ( Iterator it = classPath.iterator(); it.hasNext(); )
{
String el = (String) it.next();
- el = "file://localhost/" + el;
- cp += " " + el + ( new File( el ).isDirectory() ?
"/" : "" );
+ cp += " file://localhost/" + el + ( new File
( el ).isDirectory() ? "/" : "" );
}
Manifest.Attribute attr = new Manifest.Attribute( "Class-
Path", cp.trim() );