Hi!
> [ Not need to cc, I joined the list ]
> > > Second, suspend is not a good name for a binary. Because (as other
> > > people have brought up already) suspend is a build in command in
> > > bash.
> >
> > This was rasied a few days ago, it was decided to change name after
> > 0.2.
>
> OK, that's nice, didn't know that.
But we already did 0.2, so there's ideal time for this patch.
I guess that having s2ram and s2disk makes sense. Not sure about
s2both, I hate hardlink tricks... but I guess we can do that.
If anyone has any objections, please let me know.
> > > diff -ur suspend-0.2/Makefile trunk/Makefile
> > > --- suspend-0.2/Makefile 2006-05-01 12:40:21.000000000 +0200
> > > +++ trunk/Makefile 2006-06-27 10:39:42.000000000 +0200
> > > @@ -35,7 +39,7 @@
> > > SPLASHOBJ = splash.o bootsplash.o
> > >
> > > clean:
> > > - rm -f suspend suspend-keygen suspend.keys resume s2ram *.o
> > > vbetool/*.o vbetool/x86emu/*.o vbetool/x86emu/*.a
> > > + rm -f $(S2DISK) $(S2BOTH) suspend-keygen suspend.keys
> > > resume s2ram *.o vbetool/*.o vbetool/x86emu/*.o vbetool/x86emu/*.a
> >
> > We build an object called s2disk, s2both is just a symlink done by
> > 'install', it's not present in the source dir.
>
> Right, I made the link during my tests, not anymore. Well spotted...
>
>
> > Coding style:
> ..
>
> > Same here.
> ..
>
> > These minor issues aside I like the idea :)
>
> I will use more spaces next time, I promise;) Or do you want me to redo
> the patch?
Yes, please.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Suspend-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/suspend-devel
