On Mon, Sep 11, 2006 at 10:16:32PM +0200, Pavel Machek wrote:
> Hi!
>
> > @@ -302,6 +303,21 @@ OutS3:
> > up(&pm_sem);
> > break;
> >
> > + case SNAPSHOT_POWEROFF:
> > + if (pm_disk_mode == PM_DISK_PLATFORM) {
>
> I'd prefer to pass the pm_disk_mode as a parameter; I'd prefer not to
> depend on /sys/power/disk in uswsusp, so that /sys/power/disk can be
> eventually removed in _far_ feature.
If we want to handle it in userspace, then it does not need to be a parameter:
if (mode == platform)
ioctl(dev, SNAPSHOT_POWEROFF);
else
power_off();
I just wanted to be as "compatible" to the old stuff as possible, but i
do not really mind. Also, my patch was just a "request for thought", nothing
i deemed worth applying :-)
--
Stefan Seyfried
QA / R&D Team Mobile Devices | "Any ideas, John?"
SUSE LINUX Products GmbH, Nürnberg | "Well, surrounding them's out."
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Suspend-devel mailing list
Suspend-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/suspend-devel
