On Thu, 14 Sep 2006 10:34:38 +0200 Pavel Machek <[EMAIL PROTECTED]> wrote:
> Hi! > > > > > Also it removes the ioctls around freeze(), IIRC this is an attempt > > > > to lock against VT-switching. The way it is implemented now will > > > > make s2disk switch away from the splash VT. IMHO it is unneeded. > > > > > > Well, we can do without these ioctls, I think. > > > > > > The patch looks good. > > > > Thanks. > > > > I've played around a bit with different ioctls to lock against VT > > switching, but that would IMHO be to complicated to worth the trouble. > > If people are bitten by this I can have another look at it, but most > > probably they will just learn not to press ctr-alt-f7 in the middle of > > the suspend process ;) > > Just for the record... I'd prefer not to depend on _that_. > > "Hey, I suspended yesterday, and now I'm trying to resume, but X will > not wakeup." > > "WTF?" > > ...user may not remember he pressed c-a-f7 during suspend. Hmm, maybe your right. Although the released version has the wrong ioctl's and I haven't heard anybody complaining, yet. But that is not an excuse, I know. I haven't actually _tried_ switching away to see what happens... I'll see if I can make the locking work properly. It will probably introduce a call splash->lock, splash->unlock. Can you apply the patches now Rafeal ACK'd them? Then I'll prepare a patch on top of those. grts Tim ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Suspend-devel mailing list Suspend-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/suspend-devel
