Hi,

On Saturday, 16 September 2006 16:02, Tim Dijkstra wrote:
> Because splashy by default doesn't show the printf statements, the user
> wouldn't know that he/she would have to push a button on splash.getchar.
> This adds a prompt to splash.getchar
> 
> Index: resume.c
> ===================================================================
> diff -u -r1.29 resume.c
> --- resume.c  14 Sep 2006 14:18:58 -0000      1.29
> +++ resume.c  16 Sep 2006 13:58:14 -0000
> @@ -615,7 +615,7 @@
>                       error = load_image(&handle, dev, nr_pages);
>       }
>       if (error) {
> -             fprintf(stderr,
> +             c = splash.getchar(

Can we rename this thing to splash.dialog()?  I don't think .getchar()
should print.

>                       "\nresume: The system snapshot image could not be 
> read.\n\n"
>  #ifdef CONFIG_ENCRYPT
>                       "\tThis might be a result of booting a wrong kernel\n"
> @@ -629,7 +629,6 @@
>                       "\tnow and successful resume. That would badly damage\n"
>                       "\taffected filesystems.]\n\n"
>                       "\tDo you want to continue boot (Y/n)? ");
> -             c = splash.getchar();
>               ret = (c == 'n' || c == 'N');
>               if (ret) {
>                       close(fd);

The rest looks good, but I think we should ask Holger if he agrees with it.

Greetings,
Rafael


-- 
You never change things by fighting the existing reality.
                R. Buckminster Fuller

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Suspend-devel mailing list
Suspend-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/suspend-devel

Reply via email to