On Wed, 20 Sep 2006 01:01:26 +0200
"Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote:
> On Wednesday, 20 September 2006 00:07, Pavel Machek wrote:
> > Hi!
> >
> > > > > > > Yes, certainly.
> > > > > >
> > > > > > I'd go for 1% steps. If someone finds it slows his machine down,
> > > > > > he's the one that needs to do the benchmarking.
> > > > >
> > > > > I guess this means we should apply the Jason's patch?
> > > >
> > > > Should we also make early write the default? If I followed the thread,
> > > > I think the conclusion was that it is faster, right?
> > >
> > > Yes, I think we can do that, but let's leave the option to swich it off,
> > > at
> > > least for now.
> >
> > Ok, Rafael, can you do the commits? ;-).
>
> Generally, I can, but not in the nearest future.
Well, it is not a very big commit, and I had it in my working dir
already so I commited it. For the good order of things, this was the diff:
Index: suspend.c
===================================================================
RCS file: /cvsroot/suspend/suspend/suspend.c,v
retrieving revision 1.53
diff -u -r1.53 suspend.c
--- suspend.c 16 Sep 2006 12:52:54 -0000 1.53
+++ suspend.c 20 Sep 2006 07:40:11 -0000
@@ -417,8 +417,9 @@
m = nr_pages / 100;
if (!m)
m = 1;
- writeout_rate = nr_pages / 5;
- if (!writeout_rate || !early_writeout)
+ if (early_writeout)
+ writeout_rate = m
+ else
writeout_rate = nr_pages;
nr_pages = 0;
do {
@@ -1122,8 +1123,8 @@
if (splash_param != 'y' && splash_param != 'Y')
splash_param = 0;
- if (early_writeout != 'y' && early_writeout != 'Y')
- early_writeout = 0;
+ if (early_writeout != 'n' && early_writeout != 'N')
+ early_writeout = 1;
page_size = getpagesize();
buffer_size = BUFFER_PAGES * page_size;
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Suspend-devel mailing list
Suspend-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/suspend-devel
