On Wed, 20 Sep 2006 12:44:46 +0200 Pavel Machek <[EMAIL PROTECTED]> wrote:
> Hi! > > > Many people have udev, which will make /dev/snapshot dynamically if > > support is available in the kernel. And if it didn't, making it from the > > Makefile wouldn't be a solution because it would disappear on the next > > reboot. > > This patch adds another CONFIG option to the Makefile to not make > > /dev/snapshot. > > Otoh if we do not have udev, we make a /dev/snapshot (and nothing bad > happens), and if we do not have udev, we make a /dev/snapshot and it > helps us... So... why does this need to be configurable? Well, another reason is that, when building a package and installing with DESTDIR, the makefile will fail because of lack of privileges. Separate from other arguments, I think the patch also cleans up the Makefile. It introduces a separate target for /dev/snapshot, which removes quadruplication of code. Granted I could remove the configurability by replacing +ifndef CONFIG_UDEV +SNAPSHOT=$(DESTDIR)/dev/snapshot +endif with +SNAPSHOT=$(DESTDIR>/dev/snapshot But I think those two lines do not hurt and saves packagers (me;) the bother of having to edit the makefile everytime they sync with upstream. grts Tim ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Suspend-devel mailing list Suspend-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/suspend-devel
