Hi! > > Yeah :) > > Looks good, one small comment below. > > _However_, > > I think we can do one more thing. Namely, if the header is not continuous, > the kernel will leave the first continuous PAGE_SIZE "block" of the swap file > untouched. So, why don't we copy the swap signature into that "block", > to the place in which it would be if the the header was there, and return > its offset as the offset of the header? Then, swsusp and s2disk should work > normally as well as the swap. > > I don't think the program should do this automatically, but there may be a > flag allowing the user to modify a swap file with non-continuous header so > that it can be used for suspending.
I'm pretty sure we do not want *that* hack. ...don't we check header at offset ~4090, while writing some data to offset 0? If the file is not contiguous, this will kill data, no? Even if I'm wrong: If header is fragmented, it is likely that rest will also be fragmented and unusable, no? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Suspend-devel mailing list Suspend-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/suspend-devel