On Tue, 23 Jan 2007 10:08:44 +0100
Stefan Seyfried <[EMAIL PROTECTED]> wrote:

> On Mon, Jan 22, 2007 at 11:43:21PM +0100, Tim Dijkstra wrote:
> > Hi,
> 
> > First patch is somewhat unrelated. While fixing this I was trying to
> > get the logic of read_image(). The last part is unnecessary complex. The
> > if(!error || !ret) should always be true. The only reason I can think
> > of is reboot() failing. This patch just removes that `if' and adds 
> > some protection for a failing reboot();
> 
> This looks sane, maybe for the failed reboot a 
> 
>       while(1)
>               sleep(1);
> 
> construct would be better (i hate busy loops, even if they can never
> happen :-)

If it makes your day, I'll change that for you;)

grts Tim

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Suspend-devel mailing list
Suspend-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/suspend-devel

Reply via email to