On Thu, Mar 29, 2007 at 11:25:07PM +0200, Tim Dijkstra wrote:
> Op Thu, 29 Mar 2007 21:58:10 +0200
> schreef Stefan Seyfried <[EMAIL PROTECTED]>:
>
> > > 2) Also pass the short option string to usage and check for each
> > > `val' if it is included in the short option string. At first I
> > > thought this was a bit overkill, but thinking about it, it is more
> > > correct...
> >
> > ... this is also fine with me (and since you already have done the
> > work... :-)
> >
> > > Untested...
> >
> > tested by me. No. It doesn't apply (whitespace damaged) and after i
> > fixed that up, it did not compile.
> >
> > > What do you think?
> >
> > It does not work :-)
>
> That is because I didn't change the places which call the usage
> function, it was just a `heh, does this sound reasonable' piece
> of code... but here is a working patch:
looks good to me, although just leaving out the short options also would
be ok, but i don't care ;-)
So from my POV: go ahead and commit.
I'll follow up with a small improvement in the style of
#ifdef CONFIG_BOTH
#define MYNAME "s2both"
#else
#define MYNAME "s2disk"
#endif
and later
...
usage(MYNAME, ...);
...
but that's just a really cosmetic cleanup ;-)
--
Stefan Seyfried
"Any ideas, John?"
"Well, surrounding them's out."
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Suspend-devel mailing list
Suspend-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/suspend-devel
