On Tue, Apr 03, 2007 at 09:08:36PM +0200, Rafael J. Wysocki wrote:
> On Tuesday, 3 April 2007 15:05, Stefan Seyfried wrote:
> > On Tue, Apr 03, 2007 at 11:53:16AM +0200, Tim Dijkstra wrote:
> > > On Tue, 3 Apr 2007 11:25:23 +0200
> > > Stefan Seyfried <[EMAIL PROTECTED]> wrote:
> > >
> > > > Hi,
> > > >
> > > > This is a RFC, i am not sure if printing the program name in all error
> > > > messages is really useful, or if just "suspend:" is better there, but
> > > > at least in usage() it should be the correct one.
> > >
> > > I think I would vote for not printing the program name at all in the
> > > informational messages, only in the error messages. But I haven't given
> >
> > I think it is useful, because you can clearly see where those messages come
> > from. Users will sometimes see kernel messages and s2disk messages mixed and
> > it might be hard for them to tell which is which.
> > And yes, this is where argv[0] comes in more handy then plain "suspend",
> > since
> > it is more exact.
>
> Agreed.
ok, so i'll commit this. If there is something wrong, we can still fix it later
:-)
> > > What is this do { } while (0); thing good for?
> >
> > gcc magic, there is a good reason for it (something about breaking build
> > instead of misbehaving at runtime), but i always foreget it.
>
> http://kernelnewbies.org/FAQ/DoWhile0
>
> BTW, the ending semicolon is not necessary.
Yes. AFAICS it is even harmful, so i'll remove it in an extra commit.
--
Stefan Seyfried
"Any ideas, John?"
"Well, surrounding them's out."
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Suspend-devel mailing list
Suspend-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/suspend-devel
