Hi,

> However, this modifies the user-observable behavior in such a way that
> if the user sets 'shutdown mode = platform' in the s2disk's configuration 
> file,
> the kernel will use the hibernation mode resulting from the sysfs interface
> settings.  That is, if there is 'shutdown mode = platform' in the s2disk's
> configuration file, but the hibernation mode is set to 'reboot' in the sysfs
> interface, the system will be rebooted instead of going for the 'ACPI S0->S4
> transition'.

This I don't understand. Without looking at the code, it seems that
you're invoking some common code that checks the sysfs file. Couldn't
those functions take an argument instead? Or even kill off the ioctl
interface completely and just use whatever was in the sysfs file (and
change userland to change the sysfs file). There isn't much point in
having two separate configuration entries for one thing, imho.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Suspend-devel mailing list
Suspend-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/suspend-devel

Reply via email to