On Wed, Jun 06, 2007 at 12:02:41AM +0200, Rafael J. Wysocki wrote:
> On Tuesday, 5 June 2007 19:15, Stefan Seyfried wrote:
> > Hi,
> > 
> > while showing off encrypted suspend to interested users after my talk
> > at LinuxTag Berlin, i noticed the hard way that there is no default
> > for the "RSA key file" parameter.
> > 
> > How about this:
> > 
> > Index: encrypt.h
> > ===================================================================
> > RCS file: /cvsroot/suspend/suspend/encrypt.h,v
> > retrieving revision 1.8
> > diff -u -p -r1.8 encrypt.h
> > --- encrypt.h       23 Jan 2007 12:06:32 -0000      1.8
> > +++ encrypt.h       1 Jun 2007 11:03:22 -0000
> > @@ -58,5 +58,5 @@ void read_password(char *pass_buf, int v
> >  void encrypt_init(unsigned char *, unsigned char *, char *);
> >  void get_random_salt(unsigned char *salt, size_t size);
> >  
> > -#define KEY_FILE   ""
> > +#define KEY_FILE   "/etc/suspend.key"
> >  #endif
> > 
> > If the file is not present, it just behaves as before, and if the file
> > is present, it works as expected.
> > 
> > Is there a reason not to do this?
> 
> Not that I know of (and that I remember ;-)).

Good, then i'll commit it. I also have this as a patch in the openSUSE
package for some time, and no adverse side effects turned up until now.
-- 
Stefan Seyfried
QA / R&D Team Mobile Devices        |              "Any ideas, John?"
SUSE LINUX Products GmbH, Nürnberg  | "Well, surrounding them's out." 

This footer brought to you by insane German lawmakers:
SUSE Linux Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Suspend-devel mailing list
Suspend-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/suspend-devel

Reply via email to