Hi!
> > > I hate having to recompile the kernel, just to be able to debug suspend.
> > > Remove CONFIG_DISABLE_CONSOLE_SUSPEND, replace it by a tunable in
> > > /sys/power/disable_console_suspend.
> > >
> > >
> > > Signed-off-by: Stefan Seyfried <[EMAIL PROTECTED]>
> > > Signed-off-by: Frank Seidel <[EMAIL PROTECTED]>
> > > ---
> > > Third try, renamed sysfs interface to console_suspend
> > > reporting and expecting either "enabled" or "disabled"
> >
> > Thanks a lot for redoing it.
> >
> > I have no objections. Pavel?
>
> I still think that patch is bad. I should have screamed when
> CONFIG_DISABLE_CONSOLE_SUSPEND went into kernel. That beast should
> _not_ be configurable, it should just do the right thing.
>
> But I realized that too late. And this only makes it works, making
> that mistake part of user-kernel interface.
>
> Sorry for not screaming when CONFIG_DISABLE_CONSOLE_SUSPEND went in,
> but please lets solve this correctly....
Ouch and sorry for not screaming at "try 1" time. But it still does
not make the patch right, and I believe that even patch authors agree
that "no-config-needed" is superior solution.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Suspend-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/suspend-devel
