On Wednesday, 4 July 2007 21:33, Pavel Machek wrote: > Hi! > > > > What about this? (Only compile tested, but looks pretty obvious to > > > me). Something like this should get us rid of ugly option, and still > > > solve debugging problems... Hmmm? > > > Pavel > > > > > > Kill CONFIG_DISABLE_CONSOLE_SUSPEND; it should not be configurable at > > > all, instead, we should automatically keep console alive when > > > possible. > > > > > > Signed-off-by: Pavel Machek <[EMAIL PROTECTED]> > > > > > > diff --git a/drivers/char/lp.c b/drivers/char/lp.c > > > index 62051f8..8267ff8 100644 > > > --- a/drivers/char/lp.c > > > +++ b/drivers/char/lp.c > > > @@ -144,7 +144,7 @@ static unsigned int lp_count = 0; > > > static struct class *lp_class; > > > > > > #ifdef CONFIG_LP_CONSOLE > > > -static struct parport *console_registered; // initially NULL > > > +static struct parport *console_registered; > > > #endif /* CONFIG_LP_CONSOLE */ > > > > Could you please avoid fixing things like this, white space etc. in this > > patch? > > It would be easier to read ... > > Yep, sorry, it should be separate patch. I hope the idea is still > simple enough.
Yes, but I'm not sure if netconsole is the only one that we will want to have disabled. Moreover, what if someone wants to use the netconsole regardless of the fact that it can crash the box? Greetings, Rafael -- "Premature optimization is the root of all evil." - Donald Knuth ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Suspend-devel mailing list Suspend-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/suspend-devel
