Author: as
Date: Mon Oct 29 09:00:31 2007
New Revision: 6598
Log:
- Fixed some issues mentioned in the review.
Modified:
trunk/Url/review-1.2.txt
trunk/Url/src/url_tools.php
Modified: trunk/Url/review-1.2.txt
==============================================================================
--- trunk/Url/review-1.2.txt [iso-8859-1] (original)
+++ trunk/Url/review-1.2.txt [iso-8859-1] Mon Oct 29 09:00:31 2007
@@ -1,12 +1,14 @@
Review by Derick
================
-[ ] I am not sure if the name for the new option constant for
+[-] I am not sure if the name for the new option constant for
addUnorderedParameter() are good - the
ezcUrlConfiguration::AGGREGATE_ARGUMENTS one. Perhaps
MULTIPLE_ARRAY_ARGUMENTS would work? Or perhaps MULTIPLE_ARGUMENTS |
ARRAY_ARGUMENTS would be a viable alternative? I think the latter makes
most sense, but is slightly more to type.
+
+ I think the AGGREGATE_ARGUMENTS is better.
[ ] parseQueryString() will most likely have locale issues - needs
investigating.
@@ -21,5 +23,7 @@
Additional review by kn
=======================
-[ ] It would be nice to have some more class level documentation for
+[X] It would be nice to have some more class level documentation for
ezcUrlTools, or at least mention it only provides static methods.
+
+ - Done.
Modified: trunk/Url/src/url_tools.php
==============================================================================
--- trunk/Url/src/url_tools.php [iso-8859-1] (original)
+++ trunk/Url/src/url_tools.php [iso-8859-1] Mon Oct 29 09:00:31 2007
@@ -11,6 +11,12 @@
/**
* Class providing methods for URL parsing.
+ *
+ * Static methods contained in this class:
+ * - parseQueryString() - It implements the functionality of the PHP function
+ * parse_str(), but without converting dots to underscores in parameter
names.
+ * - getCurrentUrl() - Returns the current URL as a string from the provided
+ * array (by default $_SERVER).
*
* @package Url
* @version //autogen//
--
svn-components mailing list
svn-components@lists.ez.no
http://lists.ez.no/mailman/listinfo/svn-components
