[svn-components] 6770 - in /trunk/Feed: design/class_diagram.png src/feed.php src/processors/atom.php src/processors/rss1.php src/processors/rss2.php tests/feed_test.php

[Alexandru Stanoi]

Author: as
Date: Tue Nov 20 12:21:52 2007
New Revision: 6770

Log:
- Ignoring modules in feeds, so any feed can be parsed.

Modified:
    trunk/Feed/design/class_diagram.png
    trunk/Feed/src/feed.php
    trunk/Feed/src/processors/atom.php
    trunk/Feed/src/processors/rss1.php
    trunk/Feed/src/processors/rss2.php
    trunk/Feed/tests/feed_test.php

Modified: trunk/Feed/design/class_diagram.png
==============================================================================
Binary files - no diff available.

Modified: trunk/Feed/src/feed.php
==============================================================================
--- trunk/Feed/src/feed.php [iso-8859-1] (original)
+++ trunk/Feed/src/feed.php [iso-8859-1] Tue Nov 20 12:21:52 2007
@@ -199,6 +199,7 @@
                 break;
 
             default:
+                // should check for modules
         }
     }
 
@@ -247,7 +248,7 @@
                 return $value;
 
             default:
-                throw new ezcBasePropertyNotFoundException( $property );
+                // should check for modules
         }
     }
 

Modified: trunk/Feed/src/processors/atom.php
==============================================================================
--- trunk/Feed/src/processors/atom.php [iso-8859-1] (original)
+++ trunk/Feed/src/processors/atom.php [iso-8859-1] Tue Nov 20 12:21:52 2007
@@ -1076,6 +1076,8 @@
 
                     default:
                         // check if it's part of a known module/namespace
+                        // continue 2 = ignore modules
+                        continue 2;
                 }
             }
 

Modified: trunk/Feed/src/processors/rss1.php
==============================================================================
--- trunk/Feed/src/processors/rss1.php [iso-8859-1] (original)
+++ trunk/Feed/src/processors/rss1.php [iso-8859-1] Tue Nov 20 12:21:52 2007
@@ -473,6 +473,8 @@
 
                     default:
                         // @todo Check if it's part of a known module/namespace
+                        // continue 2 = ignore modules
+                        continue 2;
                 }
             }
 
@@ -517,6 +519,8 @@
 
                     default:
                         // @todo Check if it's part of a known module/namespace
+                        // continue = ignore modules
+                        continue;
                 }
             }
         }

Modified: trunk/Feed/src/processors/rss2.php
==============================================================================
--- trunk/Feed/src/processors/rss2.php [iso-8859-1] (original)
+++ trunk/Feed/src/processors/rss2.php [iso-8859-1] Tue Nov 20 12:21:52 2007
@@ -713,6 +713,8 @@
 
                     default:
                         // check if it's part of a known module/namespace
+                        // continue 2 = ignore modules
+                        continue 2;
                 }
             }
 
@@ -776,6 +778,8 @@
 
                     default:
                         // check if it's part of a known module/namespace
+                        // continue 2 = ignore modules
+                        continue 2;
                 }
 
                 foreach ( ezcFeedTools::getAttributes( $itemChild ) as $key => 
$value )

Modified: trunk/Feed/tests/feed_test.php
==============================================================================
--- trunk/Feed/tests/feed_test.php [iso-8859-1] (original)
+++ trunk/Feed/tests/feed_test.php [iso-8859-1] Tue Nov 20 12:21:52 2007
@@ -136,20 +136,5 @@
             $this->assertEquals( $expected, $result );
         }
     }
-
-    public function testFeedProperties()
-    {
-        $feed = new ezcFeed( 'rss2' );
-
-        try
-        {
-            $value = $feed->no_such_property;
-            $this->fail( "Expected exception was not thrown." );
-        }
-        catch ( ezcBasePropertyNotFoundException $e )
-        {
-            $this->assertEquals( "No such property name 'no_such_property'.", 
$e->getMessage() );
-        }
-    }
 }
 ?>


-- 
svn-components mailing list
svn-components@lists.ez.no
http://lists.ez.no/mailman/listinfo/svn-components