* David E. O'Brien (obr...@freebsd.org) wrote: I think this should be backed out. Those verbose messages: - Are completely unexpected, this violates POLA. - Do break recognizeable make output people are used to - Really uglify make output for some custom makefiles (for example, generated by cmake:
--- po/it.gmo --- [ 2%] Generating it.gmo --- po/kn.gmo --- [ 3%] Generating kn.gmo --- po/lv.gmo --- [ 3%] Generating lv.gmo --- po/nb.gmo --- [ 3%] Generating nb.gmo There's golden unix way rule: silence is golden. So please back this out, as this will really annoy many people. > Author: obrien > Date: Tue Jan 13 06:53:53 2009 > New Revision: 187132 > URL: http://svn.freebsd.org/changeset/base/187132 > > Log: > Don't enable -Q by default - I've fixed the rescue build issue. > > Modified: > head/usr.bin/make/job.c > head/usr.bin/make/main.c > > Modified: head/usr.bin/make/job.c > ============================================================================== > --- head/usr.bin/make/job.c Tue Jan 13 06:52:51 2009 (r187131) > +++ head/usr.bin/make/job.c Tue Jan 13 06:53:53 2009 (r187132) > @@ -2362,8 +2362,7 @@ Job_Init(int maxproc) > makeErrors = 0; > > lastNode = NULL; > - > - if ((maxJobs == 1 && fifoFd < 0) || beQuiet || beVerbose == 0) { > + if ((maxJobs == 1 && fifoFd < 0) || is_posix || beQuiet) { > /* > * If only one job can run at a time, there's no need for a > * banner, no is there? > > Modified: head/usr.bin/make/main.c > ============================================================================== > --- head/usr.bin/make/main.c Tue Jan 13 06:52:51 2009 (r187131) > +++ head/usr.bin/make/main.c Tue Jan 13 06:53:53 2009 (r187132) > @@ -126,7 +126,7 @@ Boolean is_posix; /* .POSIX target seen > Boolean mfAutoDeps; /* .MAKEFILEDEPS target seen */ > Boolean beSilent; /* -s flag */ > Boolean beVerbose; /* -v flag */ > -Boolean beQuiet = TRUE; /* -Q flag */ > +Boolean beQuiet; /* -Q flag */ > Boolean compatMake; /* -B argument */ > int debug; /* -d flag */ > Boolean ignoreErrors; /* -i flag */ > @@ -519,6 +519,7 @@ rearg: > break; > case 'Q': > beQuiet = TRUE; > + beVerbose = FALSE; > MFLAGS_append("-Q", NULL); > break; > case 'q': > _______________________________________________ > svn-src-all@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org" -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amd...@amdmi3.ru ..: jabber: amd...@jabber.ru http://www.amdmi3.ru _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
