Author: tuexen
Date: Fri May 29 12:59:18 2015
New Revision: 283726
URL: https://svnweb.freebsd.org/changeset/base/283726

Log:
  MFC r279867:
  
  Keep track on the socket lock state. This fixes a bug showing up on
  Mac OS X.

Modified:
  stable/10/sys/netinet/sctputil.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/netinet/sctputil.c
==============================================================================
--- stable/10/sys/netinet/sctputil.c    Fri May 29 12:57:04 2015        
(r283725)
+++ stable/10/sys/netinet/sctputil.c    Fri May 29 12:59:18 2015        
(r283726)
@@ -2745,7 +2745,11 @@ set_error:
 
 static void
 sctp_notify_peer_addr_change(struct sctp_tcb *stcb, uint32_t state,
-    struct sockaddr *sa, uint32_t error)
+    struct sockaddr *sa, uint32_t error, int so_locked
+#if !defined(__APPLE__) && !defined(SCTP_SO_LOCK_TESTING)
+    SCTP_UNUSED
+#endif
+)
 {
        struct mbuf *m_notify;
        struct sctp_paddr_change *spc;
@@ -2828,7 +2832,7 @@ sctp_notify_peer_addr_change(struct sctp
            control,
            &stcb->sctp_socket->so_rcv, 1,
            SCTP_READ_LOCK_NOT_HELD,
-           SCTP_SO_NOT_LOCKED);
+           so_locked);
 }
 
 
@@ -3592,7 +3596,7 @@ sctp_ulp_notify(uint32_t notification, s
 
                        net = (struct sctp_nets *)data;
                        sctp_notify_peer_addr_change(stcb, 
SCTP_ADDR_UNREACHABLE,
-                           (struct sockaddr *)&net->ro._l_addr, error);
+                           (struct sockaddr *)&net->ro._l_addr, error, 
so_locked);
                        break;
                }
        case SCTP_NOTIFY_INTERFACE_UP:
@@ -3601,7 +3605,7 @@ sctp_ulp_notify(uint32_t notification, s
 
                        net = (struct sctp_nets *)data;
                        sctp_notify_peer_addr_change(stcb, SCTP_ADDR_AVAILABLE,
-                           (struct sockaddr *)&net->ro._l_addr, error);
+                           (struct sockaddr *)&net->ro._l_addr, error, 
so_locked);
                        break;
                }
        case SCTP_NOTIFY_INTERFACE_CONFIRMED:
@@ -3610,7 +3614,7 @@ sctp_ulp_notify(uint32_t notification, s
 
                        net = (struct sctp_nets *)data;
                        sctp_notify_peer_addr_change(stcb, SCTP_ADDR_CONFIRMED,
-                           (struct sockaddr *)&net->ro._l_addr, error);
+                           (struct sockaddr *)&net->ro._l_addr, error, 
so_locked);
                        break;
                }
        case SCTP_NOTIFY_SPECIAL_SP_FAIL:
@@ -3681,15 +3685,15 @@ sctp_ulp_notify(uint32_t notification, s
                break;
        case SCTP_NOTIFY_ASCONF_ADD_IP:
                sctp_notify_peer_addr_change(stcb, SCTP_ADDR_ADDED, data,
-                   error);
+                   error, so_locked);
                break;
        case SCTP_NOTIFY_ASCONF_DELETE_IP:
                sctp_notify_peer_addr_change(stcb, SCTP_ADDR_REMOVED, data,
-                   error);
+                   error, so_locked);
                break;
        case SCTP_NOTIFY_ASCONF_SET_PRIMARY:
                sctp_notify_peer_addr_change(stcb, SCTP_ADDR_MADE_PRIM, data,
-                   error);
+                   error, so_locked);
                break;
        case SCTP_NOTIFY_PEER_SHUTDOWN:
                sctp_notify_shutdown_event(stcb);
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to