On Wed, Oct 14, 2015 at 3:09 PM, Bryan Drewery <bdrew...@freebsd.org> wrote: ... > So the reason I have been tinkering with this code is because it is so > mysterious to me, given the lack of comments and seemingly out-of-place > nature of it. > > It turns out that even moving 'buildconfig' as a recurse target creates > a surprising situation that will break with parallel builds since > 'buildconfig' is hooked into 'all', thus 'all' and 'buildconfig' both > end up recursing when calling 'make all'. This explains the make() check > here to avoid recursing if called with 'all' (even though it is checking > the opposite, only calling 'buildconfig' directly to recurse). Comments > are not a sin.
Agreed. The original change was done over a decade ago: https://svnweb.freebsd.org/base/head/share/mk/bsd.subdir.mk?r1=96667&r2=96668&pathrev=289334& . It seems that the targets used to have different names and ru@ changed them. Succinct comments would probably be a good idea in the .mk files. I'm not sure what the performance is like if bmake needs to (re-)read/(re-)evaluate make snippets. Thanks! -NGie _______________________________________________ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"