Steve Kargl wrote:
On Tue, Jun 30, 2009 at 05:17:48AM +0000, bz0...@zabbadoz.net wrote:
On Tue, 30 Jun 2009, John Baldwin wrote:
Author: jhb
Date: Tue Jun 30 03:18:51 2009
New Revision: 195181
URL: http://svn.freebsd.org/changeset/base/195181
Log:
Fix build with NFS_LEGACYRPC enabled after the socket upcall locking
changes.
is this really a good idea, considering that NFS_LEGACYRPC is on the
"removal list" for 8.0?
Yes.
1) This option definitely worked on April 18th.
2) The option was broken by a commit that was never tested! If anything
this should remind committers to either get a code review or test
their patch.
That isn't a completely fair assessment. The patch was most certainly
tested with NFS in the default configuration (!NFS_LEGACYRPC). It is
also a good idea to fix the option until such time as it is formally
removed, however.
--
John Baldwin
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
