Author: pfg
Date: Thu May  5 01:29:53 2016
New Revision: 299103
URL: https://svnweb.freebsd.org/changeset/base/299103

Log:
  MFC r298731, r298734:
  ndis(4): unsign some indexes to prevent overflows.
  
  The "len" parameter is uint32_t, indexing it with an int may
  end up in a signed integer overflow.
  
  strlen(3) returns an integer of size_t but a correponding index
  of type u_int is more than enough.

Modified:
  stable/10/sys/compat/ndis/subr_ndis.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/compat/ndis/subr_ndis.c
==============================================================================
--- stable/10/sys/compat/ndis/subr_ndis.c       Thu May  5 01:09:30 2016        
(r299102)
+++ stable/10/sys/compat/ndis/subr_ndis.c       Thu May  5 01:29:53 2016        
(r299103)
@@ -895,7 +895,7 @@ NdisReadPciSlotInformation(adapter, slot
        uint32_t                len;
 {
        ndis_miniport_block     *block;
-       int                     i;
+       uint32_t                i;
        char                    *dest;
        device_t                dev;
 
@@ -938,7 +938,7 @@ NdisWritePciSlotInformation(adapter, slo
        uint32_t                len;
 {
        ndis_miniport_block     *block;
-       int                     i;
+       uint32_t                i;
        char                    *dest;
        device_t                dev;
 
@@ -2431,7 +2431,7 @@ NdisReadPcmciaAttributeMemory(handle, of
        bus_space_handle_t      bh;
        bus_space_tag_t         bt;
        char                    *dest;
-       int                     i;
+       uint32_t                i;
 
        if (handle == NULL)
                return (0);
@@ -2461,7 +2461,7 @@ NdisWritePcmciaAttributeMemory(handle, o
        bus_space_handle_t      bh;
        bus_space_tag_t         bt;
        char                    *src;
-       int                     i;
+       uint32_t                i;
 
        if (handle == NULL)
                return (0);
@@ -2669,7 +2669,7 @@ ndis_find_sym(lf, filename, suffix, sym)
 {
        char                    *fullsym;
        char                    *suf;
-       int                     i;
+       u_int                   i;
 
        fullsym = ExAllocatePoolWithTag(NonPagedPool, MAXPATHLEN, 0);
        if (fullsym == NULL)
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to