On Fri, 13 May 2016, Don Lewis wrote:

Log:
 Mark usage() as __dead2 so that Coverity doesn't think that execution
 continues after the call and uses a negative array subscript.

 Reported by:   Coverity
 CID:           1305629

This was just a bug in Coverity.  Now it is also a style bug.

usage() doesn't return since it finishes with exit() and this is marked
with __dead2.

It is a style bug to declare usage() and similar functions that obviously
don't return as __dead2.  Thus can only be obvious only obvious for static
function.  Coverity should do more global checking and not need this markup
for some extern functions.  Even lint can do that.

Only about 32 of 451 declarations of usage() in /usr/src have this style
bug.

Bruce
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to