On Mon, May 16, 2016 at 06:56:35PM -0400, Rick Macklem wrote: > Alexey Dokuchaev wrote: > > On Sat, May 14, 2016 at 08:03:22PM +0000, Rick Macklem wrote: > > > New Revision: 299753 > > > URL: https://svnweb.freebsd.org/changeset/base/299753 > > > > > > Log: > > > Fix fuse to use DIRECT_IO when required. > > > > > > When a file is opened write-only and a partial block was written, > > > buffered I/O would try and read the whole block in. This would > > > result in a hung thread, since there was no open (fuse filehandle) > > > that allowed reading. This patch avoids the problem by forcing > > > DIRECT_IO for this case. > > > It also sets DIRECT_IO when the file system specifies the FN_DIRECTIO > > > flag in its reply to the open. > > > > Since you're at fuse now, perhaps you could also have a look at PR 195000? > > > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195000 > > I was able to test the patch and it stops the crash. > I took out the MPASS() call because I didn't see why it should panic > for VFIFO instead of returning EINVAL like the rest. > > If you'd like to commit it, email soon. Otherwise I will commit it.
Rick, if I could've committed it, I would've done it long time ago. ;-) I'm lucky to finaly drag competent src committer's attention to this PR. Please go ahead of course, no waiting required. ./danfe _______________________________________________ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
