On 5/30/16 23:24, Garrett Cooper wrote: > Author: ngie > Date: Tue May 31 06:24:09 2016 > New Revision: 301023 > URL: https://svnweb.freebsd.org/changeset/base/301023 > > Log: > Add missing libc includes to fix -Wimplicit-function-declaration warnings > > MFC after: 2 weeks > Reported by: clang > Sponsored by: EMC / Isilon Storage Division > > Modified: > head/sys/boot/geli/geliboot_crypto.c > > Modified: head/sys/boot/geli/geliboot_crypto.c > ============================================================================== > --- head/sys/boot/geli/geliboot_crypto.c Tue May 31 06:00:18 2016 > (r301022) > +++ head/sys/boot/geli/geliboot_crypto.c Tue May 31 06:24:09 2016 > (r301023) > @@ -27,6 +27,10 @@ > * $FreeBSD$ > */ > > +#include <stdio.h> > +#include <string.h> > +#include <strings.h> > + > #include "geliboot.h"
This is wrong, you shouldn't use standard C library in freestanding environment. It seems that libstand.h is explicitly excluded, why? (in geliboot.h, allanjude cc'ed): %%% /* AES-XTS implementation */ #define _STAND #define STAND_H /* We don't want stand.h in {gpt,zfs,gptzfs}boot */ #include <opencrypto/xform_enc.h> %%% Cheers,
signature.asc
Description: OpenPGP digital signature