Author: mav
Date: Tue Jul 12 17:30:37 2016
New Revision: 302666
URL: https://svnweb.freebsd.org/changeset/base/302666
Log:
Add missing breaks in I/O BAR read/write.
This could be important if any guest actually used those registers.
Reported by: Coverity
CID: 1357519, 1357520
Modified:
head/usr.sbin/bhyve/pci_e82545.c
Modified: head/usr.sbin/bhyve/pci_e82545.c
==============================================================================
--- head/usr.sbin/bhyve/pci_e82545.c Tue Jul 12 17:22:13 2016
(r302665)
+++ head/usr.sbin/bhyve/pci_e82545.c Tue Jul 12 17:30:37 2016
(r302666)
@@ -2040,6 +2040,7 @@ e82545_write(struct vmctx *ctx, int vcpu
DPRINTF("Unknown io bar write offset:0x%lx value:0x%lx
size:%d\r\n", offset, value, size);
break;
}
+ break;
case E82545_BAR_REGISTER:
if (size != 4) {
DPRINTF("Wrong register write size:%d offset:0x%lx
value:0x%lx\r\n", size, offset, value);
@@ -2092,6 +2093,7 @@ e82545_read(struct vmctx *ctx, int vcpu,
offset, size);
break;
}
+ break;
case E82545_BAR_REGISTER:
if (size != 4) {
DPRINTF("Wrong register read size:%d offset:0x%lx\r\n",
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
