Author: ian
Date: Wed Jul 27 00:08:01 2016
New Revision: 303353
URL: https://svnweb.freebsd.org/changeset/base/303353
Log:
Annotate the usb-serial drivers which always return 0 for line status,
so that it'll be easier to find and fix them in the future.
Modified:
head/sys/dev/usb/serial/u3g.c
head/sys/dev/usb/serial/uark.c
head/sys/dev/usb/serial/uchcom.c
head/sys/dev/usb/serial/ufoma.c
head/sys/dev/usb/serial/umodem.c
head/sys/dev/usb/serial/uplcom.c
head/sys/dev/usb/serial/uslcom.c
Modified: head/sys/dev/usb/serial/u3g.c
==============================================================================
--- head/sys/dev/usb/serial/u3g.c Wed Jul 27 00:03:29 2016
(r303352)
+++ head/sys/dev/usb/serial/u3g.c Wed Jul 27 00:08:01 2016
(r303353)
@@ -1100,6 +1100,7 @@ u3g_cfg_get_status(struct ucom_softc *uc
{
struct u3g_softc *sc = ucom->sc_parent;
+ /* XXX Note: sc_lsr is always zero */
*lsr = sc->sc_lsr[ucom->sc_subunit];
*msr = sc->sc_msr[ucom->sc_subunit];
}
Modified: head/sys/dev/usb/serial/uark.c
==============================================================================
--- head/sys/dev/usb/serial/uark.c Wed Jul 27 00:03:29 2016
(r303352)
+++ head/sys/dev/usb/serial/uark.c Wed Jul 27 00:08:01 2016
(r303353)
@@ -427,6 +427,7 @@ uark_cfg_get_status(struct ucom_softc *u
{
struct uark_softc *sc = ucom->sc_parent;
+ /* XXX Note: sc_lsr is always zero */
*lsr = sc->sc_lsr;
*msr = sc->sc_msr;
}
Modified: head/sys/dev/usb/serial/uchcom.c
==============================================================================
--- head/sys/dev/usb/serial/uchcom.c Wed Jul 27 00:03:29 2016
(r303352)
+++ head/sys/dev/usb/serial/uchcom.c Wed Jul 27 00:08:01 2016
(r303353)
@@ -625,6 +625,7 @@ uchcom_cfg_get_status(struct ucom_softc
DPRINTF("\n");
+ /* XXX Note: sc_lsr is always zero */
*lsr = sc->sc_lsr;
*msr = sc->sc_msr;
}
Modified: head/sys/dev/usb/serial/ufoma.c
==============================================================================
--- head/sys/dev/usb/serial/ufoma.c Wed Jul 27 00:03:29 2016
(r303352)
+++ head/sys/dev/usb/serial/ufoma.c Wed Jul 27 00:08:01 2016
(r303353)
@@ -900,6 +900,7 @@ ufoma_cfg_get_status(struct ucom_softc *
{
struct ufoma_softc *sc = ucom->sc_parent;
+ /* XXX Note: sc_lsr is always zero */
*lsr = sc->sc_lsr;
*msr = sc->sc_msr;
}
Modified: head/sys/dev/usb/serial/umodem.c
==============================================================================
--- head/sys/dev/usb/serial/umodem.c Wed Jul 27 00:03:29 2016
(r303352)
+++ head/sys/dev/usb/serial/umodem.c Wed Jul 27 00:08:01 2016
(r303353)
@@ -558,6 +558,7 @@ umodem_cfg_get_status(struct ucom_softc
DPRINTF("\n");
+ /* XXX Note: sc_lsr is always zero */
*lsr = sc->sc_lsr;
*msr = sc->sc_msr;
}
Modified: head/sys/dev/usb/serial/uplcom.c
==============================================================================
--- head/sys/dev/usb/serial/uplcom.c Wed Jul 27 00:03:29 2016
(r303352)
+++ head/sys/dev/usb/serial/uplcom.c Wed Jul 27 00:08:01 2016
(r303353)
@@ -807,6 +807,7 @@ uplcom_cfg_get_status(struct ucom_softc
DPRINTF("\n");
+ /* XXX Note: sc_lsr is always zero */
*lsr = sc->sc_lsr;
*msr = sc->sc_msr;
}
Modified: head/sys/dev/usb/serial/uslcom.c
==============================================================================
--- head/sys/dev/usb/serial/uslcom.c Wed Jul 27 00:03:29 2016
(r303352)
+++ head/sys/dev/usb/serial/uslcom.c Wed Jul 27 00:08:01 2016
(r303353)
@@ -704,6 +704,7 @@ uslcom_get_status(struct ucom_softc *uco
DPRINTF("\n");
+ /* XXX Note: sc_lsr is always zero */
*lsr = sc->sc_lsr;
*msr = sc->sc_msr;
}
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
