On 01/02/17 17:54, Conrad Meyer wrote:
I was suggesting using UINT32_MAX/2 on all platforms (which is safe everywhere).
Ah OK. INT_MAX is ~ (UINT_MAX / 2) so it's the same to use either. I just think it's clearer to use INT_MAX and the corresponding int type. The other issue is if diff(1) can handle such lines(?). Pedro.
Best, Conrad On Mon, Jan 2, 2017 at 11:48 AM Pedro Giffuni <p...@freebsd.org <mailto:p...@freebsd.org>> wrote: Hi; On 01/02/17 13:28, Conrad Meyer wrote: > IMO this patch was mostly fine, you just need to restrict line length > to UINT32_MAX/2 instead of UINT_MAX (== UINT32_MAX) for 32-bit > platforms. > > Best, > Conrad > I dislike the idea of special cases for some platforms. I guess moving to int/INT_MAX would be the way to go. TBH, no one has asked for patches wider than USHRT_MAX though. Pedro.
_______________________________________________ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
