> On Jan 4, 2017, at 15:36, Jilles Tjoelker <jil...@stack.nl> wrote:
... > It would be better to avoid naming the non-portable sun_len field if it > is just to make Coverity happy. I suggest initializing the structure > with designated initializers or memset(). > > Apart from that, the value for sun_len is wrong; it should be the length > of the whole structure and not just the sun_path part. Fortunately, the > field is ignored by bind(), which uses the addrlen parameter instead. > > On a more general note, refactoring tests without a way to verify they > have not been changed to always pass is risky :( Yeah... agreed. Unfortunately, the interest in reviewing tests is low.. some people only care when they "break" :(.. In general, I try to test all of my changes carefully, but this item fell through the cracks, due to my poor memory about how sockaddr_un is structured. Thank you for the input jilles and jmallett! > -- > Jilles Tjoelker _______________________________________________ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
