Author: mav
Date: Tue Jan 10 19:15:07 2017
New Revision: 311882
URL: https://svnweb.freebsd.org/changeset/base/311882

Log:
  MFC r309251: Process port interrupt even is PxIS register is zero.
  
  ASMedia ASM1062 AHCI chips with some fancy firmware handling PMP inside
  seems sometimes forgeting to set bits in PxIS, causing command timeouts.
  Removal of this check fixes the issue by the theoretical cost of slightly
  higher CPU usage in some odd cases, but this is what Linux does too.

Modified:
  stable/11/sys/dev/ahci/ahci.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/dev/ahci/ahci.c
==============================================================================
--- stable/11/sys/dev/ahci/ahci.c       Tue Jan 10 18:46:40 2017        
(r311881)
+++ stable/11/sys/dev/ahci/ahci.c       Tue Jan 10 19:15:07 2017        
(r311882)
@@ -1169,8 +1169,6 @@ ahci_ch_intr(void *arg)
 
        /* Read interrupt statuses. */
        istatus = ATA_INL(ch->r_mem, AHCI_P_IS);
-       if (istatus == 0)
-               return;
 
        mtx_lock(&ch->mtx);
        ahci_ch_intr_main(ch, istatus);
@@ -1187,8 +1185,6 @@ ahci_ch_intr_direct(void *arg)
 
        /* Read interrupt statuses. */
        istatus = ATA_INL(ch->r_mem, AHCI_P_IS);
-       if (istatus == 0)
-               return;
 
        mtx_lock(&ch->mtx);
        ch->batch = 1;
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to