FWIW,
On 2/20/2017 7:24 PM, Bryan Drewery wrote:
On 2/17/2017 7:40 AM, Mateusz Guzik wrote:
Author: mjg
Date: Fri Feb 17 15:40:24 2017
New Revision: 313878
URL: https://svnweb.freebsd.org/changeset/base/313878
Log:
mtx: get rid of file/line args from slow paths if they are unused
This denotes changes which went in by accident in r313877.
I really wish people would just revert their changes and recommit them
properly. The 'svn blame' on the code in r313877 will never show the
commit message here (r313878). So a person would only find this
explanation if they read 'svn log' on the file, which in the case of
sys/kern/kern_mutex.c there are 273 commits for. Are we expected to
read 'svn log' (in the future) for all changes in the hopes that a later
commit happens to mention it?
As someone who so often is 'svn blame'ing code to understand it better
and to track regressions, commits like this that explain other commits
might as well have never been done.
As I mentioned in another thread, other svn configurations (ASF, for
example) permit editing the log message:
http://help.collab.net/index.jsp?topic=/faq/changelog.html
Cheers,
Pedro.
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
