Hello,
On 2/23/2017 10:05 PM, Alexey Dokuchaev wrote:
On Thu, Feb 23, 2017 at 12:49:01PM -0500, Pedro Giffuni wrote:
On 2/23/2017 12:13 PM, Benjamin Kaduk wrote:
On Thu, Feb 23, 2017 at 9:30 AM, Pedro F. Giffuni <p...@freebsd.org
<mailto:p...@freebsd.org>> wrote:
@@ -632,8 +632,8 @@ void ce_stop_chan (ce_chan_t *c)
"UserRequest (%s:%d)\n",
__FUNCTION__, __LINE__));
return;
}
- req->Command = TAU32_Configure_Commit |
- TAU32_Tx_Stop | TAU32_Rx_Stop;
+// req->Command = TAU32_Configure_Commit |
+// TAU32_Tx_Stop | TAU32_Rx_Stop;
Should probably stick to C-style comments, though.
They are valid C99 comments but I understand what you mean,
Using comments (regardless of style) for disabling a code block is wrong;
may I suggest `#if 0' instead? (This also does not hurt `svn blame'.)
This is not covered by style(9) so I guess it's personal choice.
As I see it, '#if 0' is WIP: code that is not ready but is kept to be
enabled at later time. I would generally prefer to remove such code and
hunt it back through svn if I need it.
In this case the code is only to serve as a reference, JIC someone wants
to implement it for real.
Since the main comment starts with "XXXRIK: .." and states "it is VERY
BUGGY!!! Do not use it ... ", I just don't think it is worth to spend
much time deciding how to comment it out.
Let me CC rik@ though, maybe he has a real fix ;).
Pedro.
ps. for Roman ... we are discussing this change:
https://svnweb.freebsd.org/changeset/base/314142
Feel free to chime in if you have a cleaner workaround.
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
