On 4 Apr 2017, at 19:14, Ngie Cooper (yaneurabeya) <yaneurab...@gmail.com> wrote: > >> On Apr 4, 2017, at 09:08, Conrad Meyer <c...@freebsd.org> wrote: >> >> Author: cem >> Date: Tue Apr 4 16:08:51 2017 >> New Revision: 316492 >> URL: https://svnweb.freebsd.org/changeset/base/316492 >> >> Log: >> bsdgrep(1): Rip out "xmalloc" bits >> >> xmalloc was a debug malloc implementation, but the x{malloc,calloc,free} >> functions default to calling the malloc(3) equivalents. >> >> Instead of relying on this malloc shim, we can devise better ways to debug >> malloc issues that aren't misleading upon initial inspection. (I.e., using >> jemalloc's various built-in debugging capabilities.) >> >> Submitted by: Kyle Evans <kevans91 at ksu.edu> >> Reviewed by: emaste, cem >> Differential Revision: https://reviews.freebsd.org/D10269 >> >> Deleted: >> head/usr.bin/grep/regex/xmalloc.c >> head/usr.bin/grep/regex/xmalloc.h >> Modified: >> head/usr.bin/grep/Makefile >> head/usr.bin/grep/regex/fastmatch.c >> head/usr.bin/grep/regex/tre-compile.c >> head/usr.bin/grep/regex/tre-fastmatch.c > > Where did xmalloc.c originate from?
GNU. Almost all software from the GNU project relies on malloc wrappers which abort the program on allocation failures. > I can’t find any references to it in OpenBSD’s grep implementation (I’m > pretty sure this copy of grep started there). Not sure, they must have disliked the GNUisms too, probably. :) -Dimitry
signature.asc
Description: Message signed with OpenPGP
