> On Jun 1, 2017, at 13:06, Alexey Dokuchaev <da...@freebsd.org> wrote: > > On Thu, Jun 01, 2017 at 11:27:18AM -0700, Ngie Cooper (yaneurabeya) wrote: >> ... >> I vote for not checking in the SHAs. If something fails (as someone else >> mentioned on the lists), it's really hard to debug why it failed. > > Like I've said, it's not "really" hard. Check out previous version and > generate image with correct hash, there is no strong reason to commit the > image other than minor usability improvement of not having to check out > previous version. > > Then again, just my $.02 -- I'm not the one doing actual work here.
That’s assuming there aren’t endianness issues, and less intuitive
issues (take the usr.sbin/sa tests for example — BLEH). With binary files like
this, it’s best to do an abbreviated dump of sorts.
Thanks,
-Ngie
signature.asc
Description: Message signed with OpenPGP using GPGMail
