On Wed, Nov 04, 2009 at 06:48:34AM +0000, Edward Tomasz Napierala wrote: > Author: trasz > Date: Wed Nov 4 06:48:34 2009 > New Revision: 198874 > URL: http://svn.freebsd.org/changeset/base/198874 > > Log: > Make sure we don't end up with VAPPEND without VWRITE, if someone calls > open(2) > like this: open(..., O_APPEND). > > Modified: > head/sys/kern/vfs_vnops.c > > Modified: head/sys/kern/vfs_vnops.c > ============================================================================== > --- head/sys/kern/vfs_vnops.c Wed Nov 4 06:47:14 2009 (r198873) > +++ head/sys/kern/vfs_vnops.c Wed Nov 4 06:48:34 2009 (r198874) > @@ -213,7 +213,7 @@ restart: > if (fmode & FEXEC) > accmode |= VEXEC; > if (fmode & O_APPEND) > - accmode |= VAPPEND; > + accmode |= VWRITE | VAPPEND; > #ifdef MAC > error = mac_vnode_check_open(cred, vp, accmode); > if (error)
Why? If someone does O_APPEND only we don't want to give him write access... -- Pawel Jakub Dawidek http://www.wheel.pl p...@freebsd.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am!
pgp7CogigE5Kf.pgp
Description: PGP signature
