On 10/13/17 09:45, Adrian Chadd wrote:
no, it checks it.


-a


On 13 October 2017 at 00:11, Hans Petter Selasky <h...@selasky.org> wrote:
On 10/13/17 08:49, Adrian Chadd wrote:

         if (ieee80211_check_rxseq_amsdu_more(rxs)) {

^^^ does this line also need a NULL check?


                 ni->ni_rxseqs[tid] = rxseq;
-               if (ieee80211_check_rxseq_amsdu(rxs))
+               if ((rxs != NULL) && ieee80211_check_rxseq_amsdu(rxs))
                         IEEE80211_NODE_STAT(ni, rx_amsdu_more_end);


--HPS



Then why are you checking that pointer twice? Why not make ieee80211_check_rxseq_amsdu_more() return false, if rxs is NULL?

--HPS
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to