On 11/5/2017 10:56 AM, Ian Lepore wrote: > On Fri, 2017-11-03 at 17:22 -0400, Ed Maste wrote: >> "On 3 November 2017 at 16:42, Bryan Drewery <bdrew...@freebsd.org> >> wrote: >>> >>> >>>> >>>> Differential Revision: D12929 >>> Apparently this format closes the review now? I thought we needed a >>> full >>> URL? >> Interesting, Phabricator reports "We found a "Differential Revision" >> field with value "12929" in the commit message, and the domain on the >> URI matches this install, so we linked this commit to D12929." It >> looks like Phabricator was changed to accept only the D##### tag, but >> not the "Explain why" text. >> > > I like having the full URL, and would like that to remain the standard. > It's very useful when you're perusing svn logs and you can just click > on the url to get to the phab material cited in the commit.
Yeah despite my "\o/", I ended up sticking to the URL format myself too. > > If people want the convenience of typing the shorter info, could we > make the svn commit hooks expand it to an url? > > -- Ian > -- Regards, Bryan Drewery
signature.asc
Description: OpenPGP digital signature
